Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the bundle's configuration from XML format to PHP format, addressing issue #847. The change modernizes the dependency injection configuration by replacing XML-based service definitions with PHP-based ones.
- Replaced XML configuration files with PHP equivalents using Symfony's container configurator
- Updated the extension to use PhpFileLoader instead of XmlFileLoader
- Modified PHP-CS-Fixer configuration to include the config directory and updated migration rule names
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DependencyInjection/KnpPaginatorExtension.php | Changed from XmlFileLoader to PhpFileLoader and removed outdated docblock |
| config/templating_php.xml | Removed XML configuration file |
| config/templating_php.php | Added PHP configuration equivalent with modern container configurator syntax |
| config/paginator.xml | Removed XML configuration file |
| config/paginator.php | Added PHP configuration equivalent with comprehensive service definitions |
| .php-cs-fixer.php | Updated to include config directory and modernized migration rule names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #847